Repository navigation
Conversation
Author
|
Draft because of the base PR. |
Fixes docker#14460. If an oci artifact is sha-pinned and we have it in the cache, don't even talk to the registry. The primary use case is operational safety in case of registry failure: This allows to still work with a compose config that `includes: oci://` if it has been pulled before. This aligns the behavior with docker itself: images are kept locally, so it is not necessary for the registry to be up to, say, recreate an existing container with a modified environment. Signed-off-by: Tobias Schlatter <schlatter.tobias@gmail.com>
Author
|
Rebased on main. Ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
If an oci artifact is sha-pinned and we have it in the cache, don't
even talk to the registry.
The primary use case is operational safety in case of registry failure:
This allows to still work with a compose config that
includes: oci://if it has been pulled before.This aligns the behavior with docker itself: images are kept locally,
so it is not necessary for the registry to be up to, say, recreate an
existing container with a modified environment.
Related issue
Fixes #14460.
Changes made
Testing done
make testmake e2e-composeormake e2e-compose-standalone(fail locally, looks like infrastructure failure, similar failures on main)make lintmake fmtAdditional context
Depends / based on #14462