Repository navigation
fix(ajax): retain response status in cached results - #2813
Merged
sy-records merged 3 commits intoOct 27, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the original response status together with content and options, and pass it to callbacks on cache hits. Previously, revisiting a cached page set
vm.route.responsetoundefined, even though the first visit provided{ ok, status, statusText }.Fixes #2812.
Added a regression through the public AJAX helper, mocking only XMLHttpRequest. It compares the complete callback payload for the initial request and the cached request.
Validation:
responsewas undefined, then passed.npm run test:jest -- --runInBand: 14 suites, 125 tests, 46 snapshots passed.npm run typecheckandnpm run build: passed.git diff --check: passed.Assisted by Codex; reviewed the full diff and ran these checks locally. The full Playwright browser matrix was not run locally.