Repository navigation
fix: Use passive event listeners - #1652
Merged
silviuaavram merged 1 commit intoNov 7, 2026
Merged
Conversation
jsphstls
marked this pull request as ready for review
June 5, 2025 16:39
silviuaavram
force-pushed
the
fix/use-passive-listeners
branch
from
November 7, 2026 16:58
6434e2e to
ab9ab46
Compare
silviuaavram
approved these changes
Nov 7, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 18 69 +51
Lines 1726 1921 +195
Branches 518 598 +80
==========================================
+ Hits 1726 1921 +195 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hey @silviuaavram, thank you for approving. I am unable to merge and it is unclear why that it is. Can you merge? |
Collaborator
|
Hey @jsphstls no worries, I'm going to merge this. Thanks again for the proposed change! |
|
🎉 This PR is included in version 9.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #1650
Why:
Resolve console warnings in Chrome and potentially improve performance.
How:
Add
{ passive: true }toaddEventListenterandremoveEventListenercalls.Checklist:
These changes assume that existing tests will cover any possible regression. The behavior is not expected to change.