Skip to content

fix: Use passive event listeners - #1652

Merged
silviuaavram merged 1 commit into
downshift-js:masterfrom
jsphstls:fix/use-passive-listeners
Nov 7, 2026
Merged

silviuaavram merged 1 commit into
downshift-js:masterfrom
jsphstls:fix/use-passive-listeners

Conversation

@jsphstls

@jsphstls jsphstls commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

What:

Closes #1650

Why:

Resolve console warnings in Chrome and potentially improve performance.

How:

Add { passive: true } to addEventListenter and removeEventListener calls.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

These changes assume that existing tests will cover any possible regression. The behavior is not expected to change.

@jsphstls
jsphstls marked this pull request as ready for review June 5, 2025 16:39
@silviuaavram
silviuaavram force-pushed the fix/use-passive-listeners branch from 6434e2e to ab9ab46 Compare November 7, 2026 16:58
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (74ce0f5) to head (ab9ab46).
⚠️ Report is 29 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1652    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           18        69    +51     
  Lines         1726      1921   +195     
  Branches       518       598    +80     
==========================================
+ Hits          1726      1921   +195     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsphstls

jsphstls commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Hey @silviuaavram, thank you for approving. I am unable to merge and it is unclear why that it is. Can you merge?

@silviuaavram

Copy link
Copy Markdown
Collaborator

Hey @jsphstls no worries, I'm going to merge this. Thanks again for the proposed change!

@silviuaavram
silviuaavram merged commit c829def into downshift-js:master Nov 7, 2026
4 checks passed
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 9.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using passive event listeners

3 participants