Repository navigation
fix(useSelect): ignore repeated Space activation - #1703
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Prevent held Space from toggling a
useSelectmenu repeatedly. Related: #1197.Why
When a user holds Space while choosing an item, the first keydown selects it and closes the menu; a repeated keydown immediately opens it again. Holding Space while opening can also immediately select an item.
How
Ignore repeated Space activation when there is no typeahead query; retain repeated spaces within a query.
Changes
kcd-scripts test --runInBand --watch=false --coverage: 1,113 tests and 49 snapshots passed; reported coverage 100%.react-hooks/refsunder this installation; changed files passed with that rule disabled (four existing warnings). The web bundle was generated, but its declaration phase reported the same TypeScript errors.Codex assisted with investigation, implementation, and tests.
Checklist