Repository navigation
feat(stateReducer): add blur source when clicking outside - #1705
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that distinguishes outside dismissal from normal blur.
No open issues 🎉
What changed in this PR
Adds source: 'outside' to outside-click and touch blur actions in useSelect and useCombobox, allowing custom state reducers to distinguish outside dismissal from normal blur behavior.
Changes:
- Tags outside-triggered blur actions and updates their TypeScript types.
- Extends tests to check that outside interactions include the source and normal blurs omit it.
- Documents how to ignore outside blur actions in custom state reducers.
| File | Description |
|---|---|
src/hooks/useSelect/README.md |
Documents blur source metadata and reducer usage. |
src/hooks/useSelect/index.types.ts |
Adds optional source metadata to action types. |
src/hooks/useSelect/index.ts |
Tags outside-triggered toggle button blur actions. |
src/hooks/useSelect/__tests__/getToggleButtonProps.test.js |
Checks source metadata for outside and normal blurs. |
src/hooks/useCombobox/README.md |
Documents blur source metadata and reducer usage. |
src/hooks/useCombobox/index.types.ts |
Adds optional source metadata to action types. |
src/hooks/useCombobox/index.ts |
Tags outside-triggered input blur actions. |
src/hooks/useCombobox/__tests__/getInputProps.test.js |
Checks source metadata for outside and normal blurs. |
Review effort: Balanced
|
🎉 This PR is included in version 9.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Add {source: 'outside'} to blurs that were made by touching / clicking outside.
Why
Better distinguish the event source to make decisions.
Closes #1632.
How
Add the metadata and the types.
Changes
Add the source 'outside' property to dispatch in the click outside function.
Checklist