Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_split_path()currently passes the separator tostr.lstrip(), which removes individual separator characters. With separatorab,appleabkeybecomespple/key. If both keys exist,get()silently returns the wrong value;new()can create the wrong key.Strip only complete leading separator tokens before splitting the path. Repeated whole separators still work. Single-character separators, list paths,
Noneand empty-separator behavior are preserved.The regression tests cover partial prefixes, repeated leading separators,
get(),new(),set(),delete()andsearch(). Five tests fail against unchanged master and pass with the fix; a separate control checks existing separator behavior.Validation:
AI assistance was used to prepare and locally test this change. The reproduction uses synthetic inputs, not a claimed production incident.