Repository navigation
Allow retries with type: dynamo router - #4474
Merged
Merged
Conversation
Retry was rejected because workers got the router's internal IP once, via DSTACK_ROUTER_INTERNAL_IP, and a retried router could come back at a different address. Since #4402, Dynamo services run etcd in a dedicated group referenced via replica IP interpolation (#4177), and #4473 removed the variable, so nothing depends on the router's address anymore.
un-def
added a commit
that referenced
this pull request
Nov 12, 2026
In Dynamo 1.5.1, a vLLM prefill worker that loses etcd hangs on exit: its teardown never shuts down the EngineCore child process, so Python blocks joining it (ai-dynamo/dynamo#16401, fixed in 1.6.0). On 1.6.2, the frontend and both workers exit once their etcd leases expire. Since #4474, services with the `dynamo` router accept `retry`. Without it, a failed replica, such as etcd, fails the whole run. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry was rejected because workers got the router's internal IP once, via DSTACK_ROUTER_INTERNAL_IP, and a retried router could come back at a different address. Since #4402, Dynamo services run etcd in a dedicated group referenced via replica IP interpolation (#4177), and #4473 removed the variable, so nothing depends on the router's address anymore.