Skip to content

Allow in-place updates of services with type: dynamo router - #4475

Merged
un-def merged 1 commit into
masterfrom
pr_allow_dynamo_router_in_place_updates
Nov 10, 2026
Merged

un-def merged 1 commit into
masterfrom
pr_allow_dynamo_router_in_place_updates

Conversation

@un-def

@un-def un-def commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

The check rejected changes that would roll the router or change the router type, since workers got the router's internal IP only once. DSTACK_ROUTER_INTERNAL_IP was removed in #4473, so Dynamo services can now be updated like any other service.

Router type changes are allowed too: only the SMG worker sync reads the type, and it follows the new spec. Mid-rollout errors are expected, as old and new routers and workers are incompatible, but the error window is no worse than with stopping and re-applying.

The check rejected changes that would roll the router or change the
router type, since workers got the router's internal IP only once.
DSTACK_ROUTER_INTERNAL_IP was removed in #4473, so Dynamo services can
now be updated like any other service.

Router type changes are allowed too: only the SMG worker sync reads
the type, and it follows the new spec. Mid-rollout errors are
expected, as old and new routers and workers are incompatible, but
the error window is no worse than with stopping and re-applying.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@un-def
un-def merged commit a3d9102 into master Nov 10, 2026
26 checks passed
@un-def
un-def deleted the pr_allow_dynamo_router_in_place_updates branch November 10, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant