Repository navigation
chore(deps): stop Dependabot proposing codeql-action minor pins - #309
Merged
Merged
Conversation
Closes the loop on a recurring Dependabot PR that was a regression every
time it appeared.
The four `github/codeql-action/*` steps in `codeql.yml` and `security.yml`
are referenced as the floating major tag `@v4`, which is how GitHub
documents consuming that action -- they cut releases continuously, so a
frozen minor goes stale without anything failing to tell you.
Dependabot reads `@v4` as "pin me to an exact minor" and keeps opening a PR
to do that. The one that prompted this change proposed `@v4.37.4`, while
`@v4` already dereferenced to `v4.39.2` -- twelve releases newer:
v4 -> 1fc58d04a4d4374f921bdac573c3811c240f9c26 (== v4.39.2)
v4.37.4 -> f205ea1c3313d32999d8d6a48b4f6530d4437b38
So merging it would have moved CodeQL backwards. It would not have bought
any supply-chain integrity in exchange either: an exact minor tag is just as
mutable as `@v4`, and only a SHA pin changes that. SHA-pinning codeql-action
the way the `docker/*` steps are pinned is a separate decision, and it is
not what this PR does.
Majors are deliberately NOT ignored: a v3 -> v4 style bump changes the
runner contract and must stay visible.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes #222 stop coming back, and explains why it should be closed rather than merged.
What #222 would have done
The four
github/codeql-action/*steps incodeql.ymlandsecurity.ymluse the floating major tag@v4. Dependabot reads that as "pin me to an exact minor", so it opened a PR to rewrite them as@v4.37.4.Dereferencing both tags today:
@v4already resolves to v4.39.2, twelve releases newer than what the PR proposed. Merging it moves CodeQL backwards.It also buys no supply-chain integrity in exchange: an exact minor tag is just as mutable as
@v4. Only a SHA pin changes that, and SHA-pinning codeql-action the way thedocker/*steps are pinned is a separate decision — not what this PR does.The change
An
ignoreentry forgithub/codeql-actioncovering minor and patch updates only. Majors stay visible — a v3 → v4 style bump changes the runner contract and must not be silenced.Verified: the file still parses and the entry lands under the
github-actionsecosystem block, not another one.🤖 Generated with Claude Code