Repository navigation
chore(deps): clear the dashboard's three HIGH advisories in the lockfile - #310
Merged
Merged
Conversation
Takes `server/dashboard` from 3 HIGH + 2 moderate to 0 HIGH + 3 moderate.
Lockfile only -- `package.json` is byte-identical, so no declared dependency
range changes.
1.34.14 -> 1.34.23 @redocly/openapi-core
2.1.2 -> 2.1.7 brace-expansion
4.3.0 -> 4.3.2 js-yaml
6.1.2 -> 6.1.5 postcss-selector-parser
Why this exists as a hand-made change. Dependabot's security channel
ignores `target-branch` and always opens against the default branch, so its
PR for these three carried the same fix but aimed at `main`, where it also
collided with the regular weekly group bump for the same lockfile. Rather
than merge a lockfile into `main` ahead of `develop`, the same resolution is
reproduced here on top of the group bump, from `npm audit fix
--package-lock-only`. The Dependabot PR can be closed once this lands, and
the fix reaches `main` through the normal `develop` -> `main` promotion.
This also corrects an earlier conclusion recorded in the #299 commit
message and PR body, which called the `@redocly` advisory chain
structurally unfixable short of a breaking major. That was wrong. The claim
rested on `openapi-typescript@7.13.0` hard-requiring
`@redocly/openapi-core@^1.34.6` while the advisories list a fix in
@Redocly 2.x -- but the vulnerable packages are `brace-expansion`,
`js-yaml` and `postcss-selector-parser` *nested inside* that tree, and
their own semver ranges permit the patched versions. No major is needed.
The three remaining moderates do need @Redocly 2.x and stay open
deliberately: `@redocly/openapi-core`, `minimatch` and
`openapi-typescript`. The whole chain is a devDependency used only by
`npm run gen:api`; none of it reaches the embedded bundle.
Verified locally, because the dashboard build is not exercised by PR CI --
only by the develop pre-release image, which is too late to catch a broken
grouped bump:
- `npm ci` from this lockfile, then `npm run build` (`tsc -b && vite
build`) succeeds; the bundle lands in the embedded `dist/` as usual.
- `npm run gen:api` -- the one consumer of the bumped @Redocly -- still
runs and regenerates `src/api/generated.ts` byte-identically, so the
1.34.23 bump is behaviour-neutral for the only thing that uses it.
- `git status` shows this lockfile as the sole change: build output stays
ignored and `dist/.gitkeep` is untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes
server/dashboardfrom 3 HIGH + 2 moderate to 0 HIGH + 3 moderate. Lockfile only —package.jsonis byte-identical, so no declared dependency range changes.Why this is hand-made rather than Dependabot's own PR
Dependabot's security channel ignores
target-branchand always opens against the default branch, so its PR for these three carried the same fix but aimed atmain— where it also collided with the regular weekly group bump for the same lockfile. Rather than land a lockfile onmainahead ofdevelop, the same resolution is reproduced here on top of the group bump, straight fromnpm audit fix --package-lock-only. The fix reachesmainthrough the normaldevelop→mainpromotion.Correction to #299
The #299 commit message and PR body called the
@redoclyadvisory chain structurally unfixable short of a breaking major. That was wrong. The claim rested onopenapi-typescript@7.13.0hard-requiring@redocly/openapi-core@^1.34.6while the advisories list a fix in @Redocly 2.x — but the vulnerable packages arebrace-expansion,js-yamlandpostcss-selector-parsernested inside that tree, and their own semver ranges permit the patched versions. No major is needed.The three remaining moderates genuinely do need @Redocly 2.x and stay open deliberately:
@redocly/openapi-core,minimatch,openapi-typescript. The whole chain is adevDependencyused only bynpm run gen:api; none of it reaches the embedded bundle.Verification
Done locally, because the dashboard build is not exercised by PR CI — only by the develop pre-release image, which is too late to catch a broken grouped bump.
npm cifrom this lockfile, thennpm run build(tsc -b && vite build) succeeds; the bundle lands in the embeddeddist/as usual.npm run gen:api— the one consumer of the bumped @Redocly — still runs and regeneratessrc/api/generated.tsbyte-identically, so 1.34.23 is behaviour-neutral for the only thing that uses it.git statusshows this lockfile as the sole change: build output stays ignored anddist/.gitkeepis untouched.🤖 Generated with Claude Code