Skip to content

chore: promote develop to main (x/net 0.62.0) - #313

Merged
dvcdsys merged 2 commits into
mainfrom
develop
Nov 3, 2026
Merged

dvcdsys merged 2 commits into
mainfrom
develop

Conversation

@dvcdsys

@dvcdsys dvcdsys commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Promotes develop to main. One commit, two files — server/go.mod and server/go.sum.

golang.org/x/net v0.61.0 -> v0.62.0   (indirect)

Why it needs to reach main

Code-scanning alerts are computed against the default branch. #312 put the fix on develop, so alerts #178 (CVE-2026-78661) and #179 (CVE-2026-97045) are still open on main — they are the only two open code-scanning alerts left, and this merge is what closes them.

Both are advisories in x/net/html. Neither is reachable: go list -deps ./... shows golang.org/x/net/html is not in the build graph, which is why govulncheck reported 0 affected before and after. Trivy flags the module version rather than the imported package.

Verification

Carried over from #312, where all 8 checks passed:

  • go build ./..., go vet ./..., go test ./... — 0 failures.
  • govulncheck — 0 affected, both modules.
  • trivy fs on server/go.mod — 3 findings → 1. The one left is GO-2026-5932 (x/crypto/openpgp unmaintained), dismissed as won't-fix: its only published fix is a pseudo-version, and that package is absent from both build graphs too.

What this does not do

Merging to main builds and publishes nothing — the release workflows fire on tags. This bump ships with the next server tag, which needs its own image CVE gate at that time.

🤖 Generated with Claude Code

dvcdsys and others added 2 commits November 3, 2026 15:57
Clears the only actionable finding out of the 48 open code-scanning alerts.

    golang.org/x/net v0.61.0 -> v0.62.0  (indirect)

v0.61.0 arrived with the weekly group bump and carries two advisories in
`x/net/html`, both fixed in 0.62.0:

    CVE-2026-78661  coalescing adjacent text nodes in addText/fosterParent
    CVE-2026-97045  childTextNodesAreLiteral stops walking up the tree

Neither is reachable here: `go list -deps ./...` shows `golang.org/x/net/html`
is not in the build graph at all, which is also why `govulncheck` reported 0
affected both before and after. Trivy flags the module version rather than the
imported package, so the alerts were real as reported and are worth clearing
rather than dismissing -- a one-line indirect bump is cheaper than carrying two
permanent exceptions, and the next person reading the alert list should not have
to re-derive that the package is unused.

Verified: `go build ./...`, `go vet ./...` and `go test ./...` all pass (0
failures); `govulncheck` 0 affected; `trivy fs` on `server/go.mod` drops from 3
findings to 1.

That remaining one is GO-2026-5932 -- `golang.org/x/crypto/openpgp` is
unmaintained -- and it is deliberately left alone in both modules. Its only
"fix" is the pseudo-version 0.58.1-0.20261009181718-2f1f834330b2, and trading a
tagged release for an untagged commit is a worse trade than the finding: the
openpgp package is likewise absent from both build graphs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chore(deps): bump x/net to 0.62.0 for the two html-parser advisories
@dvcdsys
dvcdsys merged commit 5b3dbe3 into main Nov 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant