Repository navigation
Apply changes to CDT to support newer version of jsch - #1564
Merged
Merged
Conversation
jsch was recently changed in Eclipse Platform. The new version is a major new version and while the APIs CDT uses are essentially unchanged there are a few places where signatures change in such a way that the class file is different. Update the dependencies on jsch to specify the expected versions and to stop allowing the old jsch to be selected by p2 and resolver. See eclipse-platform/eclipse.platform.releng.aggregator#4042 Fixes #1563
Member
Author
|
PR created on eclipse-cdt so that it runs on Jenkins too: https://ci.eclipse.org/cdt/job/cdt/job/fix-jsch/1/ |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
jld01
reviewed
Nov 13, 2026
jonahgraham
commented
Nov 13, 2026
Co-authored-by: Jonah Graham <jonah@kichwacoders.com>
Member
Author
|
Fixed and merged. Thanks for the review @jld01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsch was recently changed in Eclipse Platform. The new version is a major new version and while the APIs CDT uses are essentially unchanged there are a few places where signatures change in such a way that the class file is different.
Update the dependencies on jsch to specify the expected versions and to stop allowing the old jsch to be selected by p2 and resolver.
See eclipse-platform/eclipse.platform.releng.aggregator#4042
Fixes #1563