Skip to content

Re-enable CompletionTest tests on macOS #906 - #4530

Merged
trancexpress merged 1 commit into
eclipse-platform:masterfrom
ravnskjaer:enable-macos-completion-tests
Nov 13, 2026
Merged

trancexpress merged 1 commit into
eclipse-platform:masterfrom
ravnskjaer:enable-macos-completion-tests

Conversation

@ravnskjaer

Copy link
Copy Markdown
Contributor

Re-enables the last four CompletionTest tests that were disabled on macOS for #906 (closed): testCompletion, testCompletionService, testCompletionUsingViewerSelection and testCompletionFreeze_bug521484. testMoveCaretBackUsesAllProcessors_bug522255 was already re-enabled in #4491.

Verification on macOS:

The test has been stabilized since it was disabled, see #3880 (#3887, #4491) and #2453 (#2484).

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   1h 4m 12s ⏱️ + 11m 56s
 8 545 tests ±0   8 305 ✅ ±0  240 💤 ±0  0 ❌ ±0 
21 507 runs  ±0  20 834 ✅ +3  673 💤  - 3  0 ❌ ±0 

Results for commit ed1e1f4. ± Comparison against base commit 53ecbfe.

♻️ This comment has been updated with latest results.

@ravnskjaer

Copy link
Copy Markdown
Contributor Author

@trancexpress since you reviewed #4491, would you mind having a look at this follow-up? It re-enables the remaining four CompletionTest tests that were disabled on macOS, verified with 50 local runs and a green macOS CI run on my fork.
Also #3880 can be closed as per my last comment #3880 (comment)

@trancexpress

Copy link
Copy Markdown
Contributor

Sure, we can always disable them again if they continue to fail in I-builds. Please rebase.

These tests were disabled on macOS in 2023 for
eclipse-platform#906,
which has since been closed. They now pass on macOS, and the test has
been stabilized since then, see
eclipse-platform#3880
and eclipse-platform#2453.

Re-enables testCompletion, testCompletionService,
testCompletionUsingViewerSelection and testCompletionFreeze_bug521484.
@ravnskjaer
ravnskjaer force-pushed the enable-macos-completion-tests branch from e55303a to ed1e1f4 Compare November 13, 2026 08:56
@ravnskjaer

Copy link
Copy Markdown
Contributor Author

Thanks. The macOS failure is unrelated: org.eclipse.ui.tests timed out and was killed (exit code 143). org.eclipse.ui.genericeditor.tests ran and the Test Results show 0 failures, so the re-enabled CompletionTest tests passed on macOS. @trancexpress could you re-run the macOS job?

@trancexpress
trancexpress merged commit ad7efa0 into eclipse-platform:master Nov 13, 2026
21 of 22 checks passed
@trancexpress

Copy link
Copy Markdown
Contributor

Thank you @ravnskjaer , lets hope the fails are gone for good.

@ravnskjaer
ravnskjaer deleted the enable-macos-completion-tests branch November 13, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants