Repository navigation
Re-enable CompletionTest tests on macOS #906 - #4530
Merged
trancexpress merged 1 commit intoNov 13, 2026
Merged
trancexpress merged 1 commit into
trancexpress merged 1 commit into
Conversation
Contributor
Contributor
Author
|
@trancexpress since you reviewed #4491, would you mind having a look at this follow-up? It re-enables the remaining four CompletionTest tests that were disabled on macOS, verified with 50 local runs and a green macOS CI run on my fork. |
Contributor
|
Sure, we can always disable them again if they continue to fail in I-builds. Please rebase. |
These tests were disabled on macOS in 2023 for eclipse-platform#906, which has since been closed. They now pass on macOS, and the test has been stabilized since then, see eclipse-platform#3880 and eclipse-platform#2453. Re-enables testCompletion, testCompletionService, testCompletionUsingViewerSelection and testCompletionFreeze_bug521484.
ravnskjaer
force-pushed
the
enable-macos-completion-tests
branch
from
November 13, 2026 08:56
e55303a to
ed1e1f4
Compare
Contributor
Author
|
Thanks. The macOS failure is unrelated: org.eclipse.ui.tests timed out and was killed (exit code 143). org.eclipse.ui.genericeditor.tests ran and the Test Results show 0 failures, so the re-enabled CompletionTest tests passed on macOS. @trancexpress could you re-run the macOS job? |
Contributor
|
Thank you @ravnskjaer , lets hope the fails are gone for good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the last four CompletionTest tests that were disabled on macOS for #906 (closed):
testCompletion,testCompletionService,testCompletionUsingViewerSelectionandtestCompletionFreeze_bug521484.testMoveCaretBackUsesAllProcessors_bug522255was already re-enabled in #4491.Verification on macOS:
mvn clean verify -pl tests/org.eclipse.ui.genericeditor.tests -Dtest=CompletionTestruns locally (the script from Failures in org.eclipse.ui.genericeditor.tests.CompletionTest #3880): all passedhttps://github.com/ravnskjaer/eclipse.platform.ui/actions/runs/41238490846/job/124647177880
The test has been stabilized since it was disabled, see #3880 (#3887, #4491) and #2453 (#2484).