Skip to content

Add tests for menu and toolbar contribution behavior - #4568

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:menu-toolbar-safety-net-tests
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:menu-toolbar-safety-net-tests

Conversation

@vogella

@vogella vogella commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

This adds MenuContributionTest and a new ToolBarManagerRendererTest case for the contribution behavior that the planned changes to contribution processing must keep. The tests check that menu bar contributions follow the active part, that a top-level menu with no visible children is hidden, and that contributions are placed by positionInParent, including the retry pass for contributions that refer to each other. They also check that popups receive targeted, aliased and generic popup contributions, that the view menu button shows after a part switch, and that visibleWhen works for toolbar contributions.

Part of #4566

Cover menu bar visibility on part activation, hiding of empty top-level
menus, positionInParent placement including the retry pass, popup
contribution targets, the view menu button and toolbar contribution
visibleWhen, so later changes to contribution processing keep this
behavior.

Part of eclipse-platform#4566

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella vogella added the plan Planned bugs/enhancements for a release label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ± 0     867 suites  ±0   1h 0m 23s ⏱️ + 6m 11s
 8 551 tests + 6   8 311 ✅ + 6  240 💤 ±0  0 ❌ ±0 
21 525 runs  +18  20 852 ✅ +18  673 💤 ±0  0 ❌ ±0 

Results for commit 50dde59. ± Comparison against base commit ad7efa0.

@vogella vogella added the test junit test related things label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan Planned bugs/enhancements for a release test junit test related things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant