Repository navigation
Conversation
Cover menu bar visibility on part activation, hiding of empty top-level menus, positionInParent placement including the retry pass, popup contribution targets, the view menu button and toolbar contribution visibleWhen, so later changes to contribution processing keep this behavior. Part of eclipse-platform#4566 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds MenuContributionTest and a new ToolBarManagerRendererTest case for the contribution behavior that the planned changes to contribution processing must keep. The tests check that menu bar contributions follow the active part, that a top-level menu with no visible children is hidden, and that contributions are placed by positionInParent, including the retry pass for contributions that refer to each other. They also check that popups receive targeted, aliased and generic popup contributions, that the view menu button shows after a part switch, and that visibleWhen works for toolbar contributions.
Part of #4566