Skip to content

Show or hide the view menu button when its items change visibility - #4569

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:view-menu-button-item-visibility
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:view-menu-button-item-visibility

Conversation

@vogella

@vogella vogella commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

The view menu button of a part stack did not follow visibility changes of the items in its view menu. StackRenderer.shouldTopRightAdjusted only reacted when the changed element's direct container was the part, which is true for the view menu itself but not for the items inside it, so a view menu whose items became visible or hidden kept its button state until the next part switch. It now walks up through nested menus to the part, and a new test in PartRenderingEngineTests covers an item whose visibility toggles.

Part of #4566

StackRenderer only refreshed the view menu button for visibility changes
of elements whose direct container is the part, which is the view menu
itself but never its items. A view menu whose items were all hidden at
creation, for example by visibleWhen, did not show its button when they
became visible until the next part switch. The check now walks up from
the item through its menus to the part.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   45m 57s ⏱️ - 8m 15s
 8 546 tests +1   8 306 ✅ +1  240 💤 ±0  0 ❌ ±0 
21 510 runs  +3  20 837 ✅ +3  673 💤 ±0  0 ❌ ±0 

Results for commit 8f71946. ± Comparison against base commit ad7efa0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant