Repository navigation
Conversation
StackRenderer only refreshed the view menu button for visibility changes of elements whose direct container is the part, which is the view menu itself but never its items. A view menu whose items were all hidden at creation, for example by visibleWhen, did not show its button when they became visible until the next part switch. The check now walks up from the item through its menus to the part. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view menu button of a part stack did not follow visibility changes of the items in its view menu.
StackRenderer.shouldTopRightAdjustedonly reacted when the changed element's direct container was the part, which is true for the view menu itself but not for the items inside it, so a view menu whose items became visible or hidden kept its button state until the next part switch. It now walks up through nested menus to the part, and a new test inPartRenderingEngineTestscovers an item whose visibility toggles.Part of #4566