Skip to content

Do not paint the selected tab fill in a CTabFolder without selected tab - #4570

Open
HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:ctabrendering-no-selected-fill-without-selection
Open

HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:ctabrendering-no-selected-fill-without-selection

Conversation

@HeikoKlare

@HeikoKlare HeikoKlare commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem

When all editors are closed, the empty editor area still looks as if an invisible editor tab were selected. Below the empty tab row and around the content area it shows a band in the color of the selected tab. With themes in which the selected tab color differs from the folder background, for example white tab cards on a gray folder, an empty editor area looks like a broken, half-drawn editor.

The cause is the custom tab content background (swt-draw-custom-tab-content-background), which the shipped themes enable for the part stacks. With it, CTabRendering extends the selected tab fill over the whole area below the tab row, whether or not the folder has a selected tab.

Solution

The selected tab fill is the background of the selected tab's content, so it is now only painted when there is a selected tab. A folder without a selected tab, in particular an empty editor area, keeps its folder background below the tab row. The tab row itself is drawn as before, and folders with a selected tab look exactly as they did.

Testing

Use the Light theme on Windows and close all editors. Before this change, a white band runs between the tab row and the area with the onboarding hints, and thin white edges run along its sides. With this change, that band and the edges show the folder background, the same light gray as the tab row.

comparison-light-theme-ide

🤖 Generated with Claude Code

When all editors are closed, the empty editor area on Windows shows a
band in the selected tab color below its empty tab row and around the
content area, as if an invisible tab were selected. With themes whose
selected tab fill differs from the folder background (e.g. white tab
cards on a gray folder), this makes an empty editor area look like a
broken, half-drawn editor. The cause is the custom tab content
background (swt-draw-custom-tab-content-background, enabled for the
editor area by the default Windows theme): CTabRendering extends the
selected tab fill over the whole area below the tab row, regardless of
whether there is a selected tab at all.

A folder without selected tab, in particular an empty one, now keeps
its folder background below the tab row. The tab row itself is drawn
as before, and folders with a selected tab are unchanged.

The selected tab fill is the background of the selected tab's content,
so it is only drawn when the folder has a selection.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@BeckerWdf

Copy link
Copy Markdown
Member

Use the Light theme on Windows

Is this specific on Windows or does this also happen on other OSes?

@HeikoKlare

Copy link
Copy Markdown
Contributor Author

Is this specific on Windows or does this also happen on other OSes?

Good question. It also happens on macOS. So I have removed the statement on Windows from the PR description.

@vogella

vogella commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

LGTM on Mac

Before

before-dark2

After

after-dark

Great to see improvement in styling.

@HeikoKlare
HeikoKlare marked this pull request as ready for review November 16, 2026 15:59
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   1h 11m 21s ⏱️ + 17m 9s
 8 548 tests +3   8 308 ✅ +3  240 💤 ±0  0 ❌ ±0 
21 516 runs  +9  20 843 ✅ +9  673 💤 ±0  0 ❌ ±0 

Results for commit 1d3166b. ± Comparison against base commit ad7efa0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants