Repository navigation
Do not paint the selected tab fill in a CTabFolder without selected tab - #4570
Open
HeikoKlare wants to merge 1 commit into
Open
HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
When all editors are closed, the empty editor area on Windows shows a band in the selected tab color below its empty tab row and around the content area, as if an invisible tab were selected. With themes whose selected tab fill differs from the folder background (e.g. white tab cards on a gray folder), this makes an empty editor area look like a broken, half-drawn editor. The cause is the custom tab content background (swt-draw-custom-tab-content-background, enabled for the editor area by the default Windows theme): CTabRendering extends the selected tab fill over the whole area below the tab row, regardless of whether there is a selected tab at all. A folder without selected tab, in particular an empty one, now keeps its folder background below the tab row. The tab row itself is drawn as before, and folders with a selected tab are unchanged. The selected tab fill is the background of the selected tab's content, so it is only drawn when the folder has a selection. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Member
Is this specific on Windows or does this also happen on other OSes? |
Contributor
Author
Good question. It also happens on macOS. So I have removed the statement on Windows from the PR description. |
Contributor
vogella
approved these changes
Nov 16, 2026
HeikoKlare
marked this pull request as ready for review
November 16, 2026 15:59
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
When all editors are closed, the empty editor area still looks as if an invisible editor tab were selected. Below the empty tab row and around the content area it shows a band in the color of the selected tab. With themes in which the selected tab color differs from the folder background, for example white tab cards on a gray folder, an empty editor area looks like a broken, half-drawn editor.
The cause is the custom tab content background (
swt-draw-custom-tab-content-background), which the shipped themes enable for the part stacks. With it,CTabRenderingextends the selected tab fill over the whole area below the tab row, whether or not the folder has a selected tab.Solution
The selected tab fill is the background of the selected tab's content, so it is now only painted when there is a selected tab. A folder without a selected tab, in particular an empty editor area, keeps its folder background below the tab row. The tab row itself is drawn as before, and folders with a selected tab look exactly as they did.
Testing
Use the Light theme
on Windowsand close all editors. Before this change, a white band runs between the tab row and the area with the onboarding hints, and thin white edges run along its sides. With this change, that band and the edges show the folder background, the same light gray as the tab row.🤖 Generated with Claude Code