Skip to content

Hide unrelated code minings while unified diff is visible - #3078

Open
tobiasmelcher wants to merge 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/filter-unified-diff-code-minings
Open

tobiasmelcher wants to merge 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/filter-unified-diff-code-minings

Conversation

@tobiasmelcher

@tobiasmelcher tobiasmelcher commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Unified diff uses code minings to display deleted lines in the editor. When problem-annotation code minings are enabled, warnings can appear inside the red diff block and break its rendering.

unified-diff-problem-code-mining-redacted

The screenshot shows a warning inserted between lines 34 and 35. It introduces an unrelated row and interrupts the red highlighting, making the deleted code look like separate fragments rather than one continuous diff block.

This change keeps only unified diff minings visible while a diff is open and restores other minings when it closes. Editor preferences and installed providers remain unchanged.

Depends on eclipse-platform/eclipse.platform.ui#4571. Merge the JFace change first, then this change once an Eclipse build includes the new API.

Use the per-viewer code mining filter to keep problem annotations and other minings from disrupting unified diff rendering. Restore normal mining visibility when the diff session ends without changing editor preferences or installed providers.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

0 files   -     54  0 suites   - 54   0s ⏱️ - 37m 49s
0 tests  -  5 022  0 ✅  -  5 000  0 💤  -  22  0 ❌ ±0 
0 runs   - 12 957  0 ✅  - 12 803  0 💤  - 154  0 ❌ ±0 

Results for commit c3475a2. ± Comparison against base commit 30dafa8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant