Repository navigation
Hide unrelated code minings while unified diff is visible - #3078
Open
tobiasmelcher wants to merge 1 commit into
Open
tobiasmelcher wants to merge 1 commit into
tobiasmelcher wants to merge 1 commit into
Conversation
Use the per-viewer code mining filter to keep problem annotations and other minings from disrupting unified diff rendering. Restore normal mining visibility when the diff session ends without changing editor preferences or installed providers.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified diff uses code minings to display deleted lines in the editor. When problem-annotation code minings are enabled, warnings can appear inside the red diff block and break its rendering.
The screenshot shows a warning inserted between lines 34 and 35. It introduces an unrelated row and interrupts the red highlighting, making the deleted code look like separate fragments rather than one continuous diff block.
This change keeps only unified diff minings visible while a diff is open and restores other minings when it closes. Editor preferences and installed providers remain unchanged.
Depends on eclipse-platform/eclipse.platform.ui#4571. Merge the JFace change first, then this change once an Eclipse build includes the new API.