Repository navigation
Route Modbus elevator to its listening port - #90
Closed
HuzaifaAbdulRehman wants to merge 2 commits into
Closed
HuzaifaAbdulRehman wants to merge 2 commits into
HuzaifaAbdulRehman wants to merge 2 commits into
Conversation
Signed-off-by: Huzaifa Abdul Rehman <huzaifarehman897@gmail.com>
Signed-off-by: Huzaifa Abdul Rehman <huzaifarehman897@gmail.com>
Member
|
Thanks @HuzaifaAbdulRehman but we do not hard code the environment variables :) |
Author
|
I hardcoded the backend port instead of configuring the server. I’ve verified a four-line correction with default and changed ports. Would you like a revision? |
Member
|
The problem is actually solved in the meantime :) So no need for revision. If you are interested, there are other tasks definitely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Traefik to the elevator's port
8502; document public port3179.Local register reads pass. Existing Windows tests: 6 passed, 2 skipped, 1 pre-existing lightSwitch timeout. Live deployment unverified.
Related to #88.