Repository navigation
fix(pglite): make close() wait for queries issued before it - #1170
Merged
tdrz merged 1 commit intoOct 28, 2026
Merged
Conversation
close() only took the query mutex, but query(), exec() and transaction() take the transaction mutex first. A call issued just before close() could therefore reach the query mutex after teardown and fail with "Cannot read properties of undefined". Take the transaction mutex too. Fixes electric-sql#1168
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tdrz
self-requested a review
October 28, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1168
Problem
close()only waited on the query mutex. But the publicquery(),exec()andtransaction()take the transaction mutex first and the query mutex second. So a call issued just beforeclose()can still be waiting on the transaction mutex whenclose()grabs the query mutex, sets#closingand tears down the module. Once that call reaches the query mutex, it runs against the torn-down module and fails with:Fix
close()now takes the transaction mutex around the existing query-mutex section. Anything queued throughquery(),exec()ortransaction()beforeclose()finishes first, and only then does teardown begin. Nothing else changes: init still isn't blocked, and the_checkReady()re-check for concurrentclose()calls is still in place.Tests
close waits for queries issued before ittotests/basic.test.ts(runs for both ESM and CJS). It starts aquery(), anexec()and atransaction()without awaiting them, callsclose(), and then checks that all three resolve with their results. Onmainit fails with the error above. With this change it passes.vitestovertests/**(thetest:basicset): 321 passed, 1 skipped.tests/targets/runtimes/node-*: 12 passed.pnpm stylecheckandpnpm typecheckare clean.@electric-sql/pglite.I tested locally against the wasm build artifacts from the latest
mainCI run.I used an AI coding assistant to write this change. I reviewed it and ran the tests above.