Skip to content

build: bump secret-service-action to v1.1.0 - #4451

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and found no bugs. A human should still look before merging because this step hands out the release job's GitHub token, and I couldn't check the new commit SHA against upstream from here.

What was reviewed:

  • The one-line change to the SHA pin of electron/secret-service-action in .github/workflows/release.yml. It is still pinned to a full SHA with a # v1.1.0 comment.
  • The next step, "Create GitHub release", still reads fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN. The step's inputs and outputs are unchanged.
  • Not verified: that 23b9042f797e34674f0fe2c91608f57f9661ccf2 is the v1.1.0 tag and that it still provides a secrets output with GITHUB_TOKEN.
Extended reasoning...

The change bumps the pinned commit of the third-party electron/secret-service-action in the release workflow. That action fetches the GitHub token that the "Create GitHub release" step uses, so it handles credentials in the publish job. This review could not reach upstream to confirm that the new SHA matches the v1.1.0 tag or to read what changed between the two versions. .github/CODEOWNERS assigns every path to the ecosystem working group, which also rules out an automated approval.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:42
@MarshallOfSound
MarshallOfSound merged commit fdb682c into main Oct 22, 2026
25 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants