Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Missing local credentials and premature hostapd startup can abort deployment, and the Vault helper accepts invalid passphrase lengths.
3 open issues
What changed in this PR
This PR adds static network-scanner configuration without automatic discovery. It also extends the router role with a WPA2 Wi-Fi access point and local Ansible Vault support.
Changes:
- Add an optional
sane_airscanrole and scanner deployment tag. - Configure hostapd through the router role.
- Add encrypted passphrase creation, deployment prompts, and setup documentation.
| File | Description |
|---|---|
scripts/deploy |
Add explicit and automatic Vault password prompts. |
scripts/create-router-access-point-vault |
Create an encrypted access-point passphrase file. |
README.md |
Document scanner and Wi-Fi access-point setup. |
ansible/roles/sane_airscan/templates/airscan.conf.j2 |
Define static scanners and disable discovery. |
ansible/roles/sane_airscan/tasks/main.yml |
Install scanner packages and configure backends. |
ansible/roles/sane_airscan/defaults/main.yml |
Define optional scanner settings. |
ansible/roles/router/templates/hostapd.conf.j2 |
Configure the WPA2 access point. |
ansible/roles/router/tasks/main.yml |
Validate access-point settings and manage hostapd. |
ansible/roles/router/handlers/main.yml |
Add a hostapd restart handler. |
ansible/roles/router/defaults/main.yml |
Define optional access-point defaults. |
ansible/playbooks/workstation.yml |
Include the scanner role and tag. |
ansible/inventories/production/host_vars/localhost/main.yml |
Enable local router, access-point, and scanner settings. |
ansible/inventories/production/host_vars/localhost.yml |
Remove the previous flat localhost variables file. |
.vscode/tasks.json |
Add the scanner deployment option. |
.gitignore |
Exclude the local encrypted Vault file. |
Review effort: Balanced
| name: hostapd | ||
| masked: false | ||
| enabled: true | ||
| state: started |
Contributor
There was a problem hiding this comment.
Deferred hostapd startup and its notified restart until the configured LAN interface exists, while still enabling the service for after reboot. Commit: fd575fc.
| exit 1 | ||
| fi | ||
|
|
||
| vault_dir="$(dirname "${VAULT_FILE}")" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


…hi discovery