Repository navigation
Conversation
This updates libcxxabi from 22.1.8 to LLVM 23.1.3: https://github.com/llvm/llvm-project/releases/tag/llvmorg-23.1.3
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (4) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_except.json: 197175 => 197175 [+0 bytes / +0.00%] codesize/test_codesize_cxx_mangle.json: 263425 => 264234 [+809 bytes / +0.31%] codesize/test_codesize_cxx_noexcept.json: 155014 => 155014 [+0 bytes / +0.00%] codesize/test_minimal_runtime_code_size_hello_embind.json: 15196 => 15196 [+0 bytes / +0.00%] Average change: +0.08% (+0.00% - +0.31%) ```
aheejin
marked this pull request as ready for review
October 30, 2026 03:14
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the internal libcxxabi to LLVM 23.1.3, including various refactorings such as replacing attribute-based noreturn annotations with C++11 [[noreturn]] attributes, updating constinit usage, and adding support for C++26 pack indexing in the demangler. Additionally, it introduces pointer field protection ABI macros and updates code size test expectations. I have no feedback to provide as there were no review comments to evaluate.
sbc100
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates libcxxabi from 22.1.8 to LLVM 23.1.3:
https://github.com/llvm/llvm-project/releases/tag/llvmorg-23.1.3