Repository navigation
Conversation
rudrakhp
commented
Oct 20, 2026
| `RateLimit-Remaining-Minutes`). This can be enabled together with | ||
| `LIMIT_RESPONSE_HEADERS_ENABLED`, which continues to add its three standard | ||
| headers for the descriptor closest to its limit. | ||
| `RateLimit-Limit-<Multiplier>-<Unit>` and `RateLimit-Remaining-<Multiplier>-<Unit>` headers for the |
Member
Author
There was a problem hiding this comment.
Went with adding a <Multiplier>- prefix in the existing response headers instead of adding a dedicated header for the unit multiplier as it made more sense for someone consuming them.
rudrakhp
force-pushed
the
rls_unit_multiplier
branch
from
October 20, 2026 08:07
354ca46 to
27a9b26
Compare
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
rls_unit_multiplier
branch
from
October 20, 2026 08:33
27a9b26 to
5166313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
unit_multiplierin rate limit descriptors for rate limit service. Added tests and README as well.Related envoyproxy/envoy#47307
Fixes envoyproxy/envoy#33277