Repository navigation
Conversation
fromNumeric() used new self, so PositiveInteger::fromNumeric('-42') and
NonNegativeInteger::fromNumeric('-1') returned a plain Integer without
running the subclass constructor checks. Use new static instead.
Add tests covering fromNumeric for Integer, PositiveInteger and
NonNegativeInteger.
Bump the composer platform to 8.0 and declare a php >=8.0 requirement. Refresh composer.lock content hash.
Drop PHP 7.4 from the matrix, add 8.4 and 8.5, and run mutation tests on every version now that the 7.4 exclusion is moot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Integer::fromNumeric()usednew self, so it always returned a plainIntegerand skipped subclass validation.PositiveInteger::fromNumeric('-42')andPositiveInteger::fromNumeric('0')succeeded, as didNonNegativeInteger::fromNumeric('-1').Fix
Use
new static. The declared return type staysself(project targets PHP 7.4).Tests
fromNumericreturns the called class; rejects invalid values (negative string, negative float, zero for Positive); NonNegative accepts'0'.Integer, rejects non-numeric strings.Full suite passes (55 tests).