Repository navigation
fix(fmuobs): avoid duplicate log output from submodule loggers - #893
Merged
Merged
Conversation
- Set the level on the "subscript.fmuobs" logger separately - Clear handlers on submodule loggers so records propagate only to the parent handlers and are not printed twice
There was a problem hiding this comment.
🟡 Changes recommended
A regression test must capture stream output and assert that a submodule message is printed exactly once, because the existing tests still pass when duplicate output occurs.
1 open issue
What changed in this PR
This PR fixes duplicate log output in FMUOBS by relying on parent handlers to emit records from submodule loggers.
Changes:
- Sets the
subscript.fmuobslogger level separately. - Preserves submodule log levels while clearing their handlers to avoid duplicate output.
| File | Description |
|---|---|
src/subscript/fmuobs/fmuobs.py |
Updates logging configuration so submodule records propagate without duplicate local handling. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 84.47% 84.47%
=======================================
Files 49 49
Lines 7567 7570 +3
=======================================
+ Hits 6392 6395 +3
Misses 1175 1175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Add test running fmuobs in a subprocess and counting stdout lines - Guard against duplicate output from multiple logging handlers - Needed because caplog captures only at the root logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #894