[finger563]

Summary

The follow-up promised in #869: the Tab5 was the one audio BSP still carrying its own copy of the I2S TX feeding policy that #868 introduced. It now uses the shared espp::i2s_tx_feed header from components/codec like the other nine boards.

• audio_task_callback() is attach_current_task() + fill_block() + the I2S write; the misaligned-stream reset is reported by the feeder and logged here.
• play_audio() calls notify_if_block_ready() after a successful send (send -> notify -> return).
• The ring depth and the static_assert use the header's constants and ring_outlasts_wait() against the Tab5's own UPDATE_FREQUENCY.
• The init failure path calls detach_task() before stopping the playback task.
• The two per-instance members (audio_tx_task_handle_, audio_tx_was_flowing_) are replaced by one Feeder, and the long explanation block is gone in favour of a pointer at the header.

No behaviour change intended: same 12 x 240 ring, same 24 ms bounded wait, same whole-block writes, same stream and trigger level. The Tab5's own specifics (full-duplex RX channel, the microphone task, the ES8388/ES7210 codec setup, the frame-aligned producer) are untouched.

Test plan

• components/m5stack-tab5/example builds for esp32p4 (IDF 6.1, component manager off) with no warnings in the touched files
• Tab5 (ST71xx, ESP-IDF v6.1) by ear: clicks (single and continuous) and recorded playback, same as the fix(m5stack-tab5): keep the I2S DMA ring full (pops since #845); play the click WAV's data chunk only #868 head
• CI (green on d44b349; re-running on dc0a6d6)

🤖 Generated with Claude Code

https://claude.ai/code/session_01DFjjnq3XCTRAXENSxsCxJU

[github-actions]

✅Static analysis result - no issues found! ✅

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

2 open issues

• Storing espp::i2s_tx_feed::Feeder by value in the public header forces all translation units… · New
• The updated warning loses key diagnostics that were previously logged (e.g., how many bytes were… · New

What changed in this PR

Refactors the M5Stack Tab5 audio playback path to use the shared espp::i2s_tx_feed feeding policy (as introduced elsewhere in the repo), removing the Tab5-specific duplicated implementation while keeping behavior consistent.

Changes:

• Replace Tab5-local I2S TX feed policy (whole-block writes, bounded wait, ring sizing) with the shared espp::i2s_tx_feed::Feeder.
• Update playback signaling to use notify_if_block_ready() and centralize misalignment handling via the feeder.
• Use shared DMA ring constants and helper (ring_outlasts_wait) for the I2S TX ring safety static assert.

File	Description
components/​m5stack-tab5/​src/​audio.cpp	Switches playback task and producer notification logic to the shared I2S TX feeder implementation and constants.
components/​m5stack-tab5/​include/​m5stack-tab5.hpp	Replaces per-instance playback state with a shared Feeder member and adds the feeder header include.

_{Review effort: Lite}