Skip to content

fix(ci): disable the mdns console CLI in the camera examples - #883

Merged
finger563 merged 1 commit into
mainfrom
fix/mdns-console-cli
Nov 4, 2026
Merged

finger563 merged 1 commit into
mainfrom
fix/mdns-console-cli

Conversation

@finger563

Copy link
Copy Markdown
Contributor

Description

Newer espressif/mdns releases enable CONFIG_MDNS_ENABLE_CONSOLE_CLI by default, and the component's CMake then errors out unless console is in the build:

CMake Error at managed_components/espressif__mdns/CMakeLists.txt:80 (message):
  CONFIG_MDNS_ENABLE_CONSOLE_CLI is enabled but the console component is not
  in the build.

The esp32-timer-cam and xiao-esp32s3-sense examples use mdns (for RTSP discovery) but not the console, so this turns the option off in their sdkconfig.defaults. These two examples currently fail CI on every PR (e.g. #881 and #882).

Testing

Both examples configure and build locally (ESP-IDF 6.1; esp32 and esp32s3), with the mdns release that has the option.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY

Newer espressif/mdns releases enable CONFIG_MDNS_ENABLE_CONSOLE_CLI by
default, which fails CMake configuration unless the console component is in
the build. The esp32-timer-cam and xiao-esp32s3-sense examples use mdns but
not the console, so turn the option off in their sdkconfig.defaults.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
Copilot AI balanced review requested due to automatic review settings November 4, 2026 21:02
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

✅Static analysis result - no issues found! ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

What changed in this PR

Disables the mDNS console CLI in two camera-related ESP-IDF examples to prevent build failures introduced by newer espressif/mdns defaults requiring the console component.

Changes:

  • Add CONFIG_MDNS_ENABLE_CONSOLE_CLI=n to sdkconfig.defaults for xiao-esp32s3-sense example.
  • Add CONFIG_MDNS_ENABLE_CONSOLE_CLI=n to sdkconfig.defaults for esp32-timer-cam example.
File Description
components/​xiao-esp32s3-sense/​example/​sdkconfig.defaults Turns off mDNS console CLI to avoid mdns CMake error when console isn’t included.
components/​esp32-timer-cam/​example/​sdkconfig.defaults Turns off mDNS console CLI to avoid mdns CMake error when console isn’t included.

Review effort: Lite

@finger563
finger563 merged commit c7f327b into main Nov 4, 2026
179 of 180 checks passed
@finger563
finger563 deleted the fix/mdns-console-cli branch November 4, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants