Repository navigation
fix(ci): disable the mdns console CLI in the camera examples - #883
Merged
Merged
Conversation
Newer espressif/mdns releases enable CONFIG_MDNS_ENABLE_CONSOLE_CLI by default, which fails CMake configuration unless the console component is in the build. The esp32-timer-cam and xiao-esp32s3-sense examples use mdns but not the console, so turn the option off in their sdkconfig.defaults. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Disables the mDNS console CLI in two camera-related ESP-IDF examples to prevent build failures introduced by newer espressif/mdns defaults requiring the console component.
Changes:
- Add
CONFIG_MDNS_ENABLE_CONSOLE_CLI=ntosdkconfig.defaultsforxiao-esp32s3-senseexample. - Add
CONFIG_MDNS_ENABLE_CONSOLE_CLI=ntosdkconfig.defaultsforesp32-timer-camexample.
| File | Description |
|---|---|
| components/xiao-esp32s3-sense/example/sdkconfig.defaults | Turns off mDNS console CLI to avoid mdns CMake error when console isn’t included. |
| components/esp32-timer-cam/example/sdkconfig.defaults | Turns off mDNS console CLI to avoid mdns CMake error when console isn’t included. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Newer
espressif/mdnsreleases enableCONFIG_MDNS_ENABLE_CONSOLE_CLIby default, and the component's CMake then errors out unlessconsoleis in the build:The
esp32-timer-camandxiao-esp32s3-senseexamples use mdns (for RTSP discovery) but not the console, so this turns the option off in theirsdkconfig.defaults. These two examples currently fail CI on every PR (e.g. #881 and #882).Testing
Both examples configure and build locally (ESP-IDF 6.1; esp32 and esp32s3), with the mdns release that has the option.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY