Repository navigation
Misc - do not set section attribute multiple times - #9334
Merged
Merged
Conversation
> cores/esp8266/core_esp8266_si2c.cpp:268:44: warning: ignoring attribute 'section ("\".iram.text.core_esp8266_si2c.cpp.268.16\"")' because it conflicts with previous 'section ("\".iram.text.core_esp8266_si2c.cpp.148.12\"")' [-Wattributes]
> 268 | void IRAM_ATTR Twi::busywait(unsigned int v)
> | ^
> cores/esp8266/core_esp8266_si2c.cpp:148:20: note: previous declaration here
> 148 | void IRAM_ATTR busywait(unsigned int v);
> | ^~~~~~~~
etc.
continue fixes of section attribute being set multiple times also clears up declarations incorrectly placing attr intended for func
> cores/esp8266/core_esp8266_phy.cpp:317:85: warning: ignoring attribute 'section ("\".iram.text.core_esp8266_phy.cpp.317.2\"")' because it conflicts with previous 'section ("\".iram.text.core_esp8266_phy.cpp.303.1\"")' [-Wattributes]
> 317 | extern int IRAM_ATTR __wrap_spi_flash_read(uint32_t addr, uint32_t* dst, size_t size)
> | ^
> cores/esp8266/core_esp8266_phy.cpp:303:22: note: previous declaration here
> 303 | extern int IRAM_ATTR __wrap_spi_flash_read(uint32_t addr, uint32_t* dst, size_t size);
> | ^~~~~~~~~~~~~~~~~~~~~
mcspr
force-pushed
the
section-attr-unique
branch
from
November 5, 2026 09:31
3df01c3 to
0a34429
Compare
section name is already used as string, do not assume it is a literal injected somewhere e.g. for asm hints after `.section`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
IRAM_ATTRandICACHE_FLASH_ATTRboth generate unique names, header and compilation unit receive different values.and etc.