Skip to content

add --unsupported filter to "s3 partitions" command - #394

Merged
Gerrit91 merged 2 commits into
masterfrom
feature/s3-partitions-add-class-filter
Oct 19, 2026
Merged

Gerrit91 merged 2 commits into
masterfrom
feature/s3-partitions-add-class-filter

Conversation

@TLINDEN

@TLINDEN TLINDEN commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR adds the flag --unsupported to the s3 partitions sub command, which shows deprecated partitions.

@TLINDEN
TLINDEN requested a review from a team as a code owner October 15, 2026 09:30
Comment thread cmd/s3.go Outdated
result = response.Payload
} else {
for _, part := range response.Payload {
if *part.Classification == "CLASSIFICATION_SUPPORTED" {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classification is a pointer, so if part.Classification != nil && or if pointer.SafeDeref(part.Classification) == would be cleaner.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, != nil doesn't work because every partition has a classification. I added the safederef however.

@majst01

majst01 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR adds the flag --supported to the s3 partitions sub command, which hides deprecated partitions.

I would prefer to make this reverse, and add a flag --unsupported which shows the deprecated partitions

w/o any flag only supported partitions will be shown. If --unsupported is
specified, deprecated ones will be shown as well.
@TLINDEN

TLINDEN commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Description

This PR adds the flag --supported to the s3 partitions sub command, which hides deprecated partitions.

I would prefer to make this reverse, and add a flag --unsupported which shows the deprecated partitions

Ok, changed the PR accordingly.

@mwennrich mwennrich changed the title add --supported filter to "s3 partitions" command add --unsupported filter to "s3 partitions" command Oct 15, 2026
@Gerrit91
Gerrit91 merged commit a2badf9 into master Oct 19, 2026
5 checks passed
@Gerrit91
Gerrit91 deleted the feature/s3-partitions-add-class-filter branch October 19, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants