Repository navigation
add --unsupported filter to "s3 partitions" command - #394
Conversation
| result = response.Payload | ||
| } else { | ||
| for _, part := range response.Payload { | ||
| if *part.Classification == "CLASSIFICATION_SUPPORTED" { |
There was a problem hiding this comment.
Classification is a pointer, so if part.Classification != nil && or if pointer.SafeDeref(part.Classification) == would be cleaner.
There was a problem hiding this comment.
ok, != nil doesn't work because every partition has a classification. I added the safederef however.
I would prefer to make this reverse, and add a flag |
w/o any flag only supported partitions will be shown. If --unsupported is specified, deprecated ones will be shown as well.
Ok, changed the PR accordingly. |
Description
This PR adds the flag
--unsupportedto thes3 partitionssub command, which shows deprecated partitions.