Skip to content

feat: add warning for pinning firewall-controller version in cluster creation and update - #396

Merged
mwennrich merged 1 commit into
masterfrom
add-firewallcontroller-update-warning
Nov 5, 2026
Merged

mwennrich merged 1 commit into
masterfrom
add-firewallcontroller-update-warning

Conversation

@mwennrich

@mwennrich mwennrich commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

$ cloudctl cluster update 0c2127f6-4bd2-46be-85f3-2b2b86d36e96 --firewallcontroller v2.5.0 

WARNING: You are going to pin the firewall-controller version of cluster "mwen-fel" to "v2.5.0" instead of "auto".

This prevents the firewall-controller from being updated automatically and may leave your cluster without security fixes and new features.

Are absolutely sure? (y/n)

@mwennrich
mwennrich marked this pull request as ready for review November 5, 2026 09:24
@mwennrich
mwennrich requested a review from a team as a code owner November 5, 2026 09:24
@mwennrich
mwennrich merged commit c0d3525 into master Nov 5, 2026
5 checks passed
@mwennrich
mwennrich deleted the add-firewallcontroller-update-warning branch November 5, 2026 09:25
Comment thread cmd/cluster.go
This prevents the firewall-controller from being updated automatically and may leave your cluster without security fixes and new features.

`, firewallController)
if err := helper.Prompt("Are absolutely sure? (y/n)", "y"); err != nil {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err := helper.Prompt("Are absolutely sure? (y/n)", "y"); err != nil {
if err := helper.Prompt("Are you absolutely sure? (y/n)", "y"); err != nil {

Comment thread cmd/cluster.go
This prevents the firewall-controller from being updated automatically and may leave your cluster without security fixes and new features.

`, *current.Name, firewallController)
if err := helper.Prompt("Are absolutely sure? (y/n)", "y"); err != nil {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err := helper.Prompt("Are absolutely sure? (y/n)", "y"); err != nil {
if err := helper.Prompt("Are you absolutely sure? (y/n)", "y"); err != nil {

@mwennrich mwennrich mentioned this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants