Repository navigation
Conversation
added 19 commits
October 13, 2026 13:45
l0wl3vel
reviewed
Oct 16, 2026
Comment on lines
113
to
114
| pgName = "postgresql" | ||
| ) |
Collaborator
There was a problem hiding this comment.
please remove/split this constant. It is used in multiple different contexts with no shared meaning between each other, harming readability by disturbing your reading flow.
- Name of the CRD Kind
- friendly names for ports
- accessing a field named
postgresqlin the unstructured json representation
Collaborator
Author
There was a problem hiding this comment.
fixed, we have now goconst disabled and ade6a5f reverted.
l0wl3vel
reviewed
Oct 16, 2026
l0wl3vel
left a comment
Collaborator
There was a problem hiding this comment.
otherwise looks good. thanks for taking care of it
Comment on lines
+31
to
+32
| # re-enable when todo's are done | ||
| #- godox |
added 2 commits
November 16, 2026 10:42
This reverts commit ade6a5f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR satisfies all linter issues through the whole code. We disable a couple of linters where they don't make sense for us.
It also migrates from the deprecated
Scheme.Builderto the newruntime.NewSchemeBuilder.