Skip to content

fix all linting issues once and forever - #640

Draft
TLINDEN wants to merge 21 commits into
mainfrom
lint/fixall
Draft

TLINDEN wants to merge 21 commits into
mainfrom
lint/fixall

Conversation

@TLINDEN

@TLINDEN TLINDEN commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

This PR satisfies all linter issues through the whole code. We disable a couple of linters where they don't make sense for us.

It also migrates from the deprecated Scheme.Builder to the new runtime.NewSchemeBuilder.

@TLINDEN
TLINDEN requested a review from l0wl3vel October 13, 2026 11:48
@TLINDEN TLINDEN self-assigned this Oct 13, 2026

@l0wl3vel l0wl3vel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming of the fields in the goconst linter fixes makes readability worse imo.

e.g. labelName for "app.kubernetes.io/name", True for "true", pgName that is defined a dozen times in different modules for "postgres"

ade6a5f

Comment thread api/v1/postgres_types.go Outdated
Comment on lines 113 to 114
pgName = "postgresql"
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove/split this constant. It is used in multiple different contexts with no shared meaning between each other, harming readability by disturbing your reading flow.

  1. Name of the CRD Kind
  2. friendly names for ports
  3. accessing a field named postgresql in the unstructured json representation

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, we have now goconst disabled and ade6a5f reverted.

@l0wl3vel l0wl3vel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good. thanks for taking care of it

Comment thread .golangci.yaml
Comment on lines +31 to +32
# re-enable when todo's are done
#- godox

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

Thomas von Dein added 2 commits November 16, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants