Skip to content

Fix escalation lookup by escalation code #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohith1551 wants to merge 2 commits into
base: main
Choose a base branch
from
+37 −3
Open

Fix escalation lookup by escalation code #4308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a47ab2
Fix escalation lookup by escalation code
Rohith1551 Oct 13, 2026
c1bf589
Add license header to BpmnModelTest
Rohith1551 Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/flowable-bpmn-model/src/main/java/org/flowable/bpmn/model/BpmnModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,9 @@ public void setEscalations(Map<String, Escalation> escalationMap) {
this.escalationMap = escalationMap;
}

public void addEscalation(String escalationRef, String escalationCode, String name) {
if (StringUtils.isNotEmpty(escalationRef)) {
escalationMap.put(escalationRef, new Escalation(escalationRef, name, escalationCode));
public void addEscalation(String id, String escalationCode, String name) {
if (StringUtils.isNotEmpty(escalationCode)) {
escalationMap.put(escalationCode, new Escalation(id, name, escalationCode));
}
}

Expand Down
34 changes: 34 additions & 0 deletions modules/flowable-bpmn-model/src/test/java/org/flowable/bpmn/model/BpmnModelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.flowable.bpmn.model;

@dbmalkovsky dbmalkovsky Oct 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the standard license header to this new file. Thanks

@Rohith1551 Rohith1551 Oct 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I've added the standard Apache license header to the test file.


import static org.assertj.core.api.Assertions.assertThat;

import org.junit.jupiter.api.Test;

class BpmnModelTest {

@Test
void addEscalationStoresByEscalationCode() {
BpmnModel model = new BpmnModel();

model.addEscalation("ESCALATION_ID", "ESCALATION_CODE", "Payment failed");

assertThat(model.containsEscalationRef("ESCALATION_CODE")).isTrue();
assertThat(model.getEscalation("ESCALATION_CODE")).isNotNull();
assertThat(model.containsEscalationRef("ESCALATION_ID")).isFalse();
assertThat(model.getEscalation("ESCALATION_CODE").getEscalationCode())
.isEqualTo("ESCALATION_CODE");
}
}