Skip to content

Ending a session writes no activity row #3207

Open

Description

@pournasserian

Sign-ins write an activity row (SignInEvents), but nothing does when a session ends: a logout at /connect/logout, DELETE /me/sessions/{id}, an admin ending a user's or a member's sessions, and the revocations that #3198 adds (another user's sign-in over a live cookie, a required second factor). Someone reading the activity of an account sees it sign in and never sees it sign out or be signed out, and by whom.

Expected

One activity row per ended session or per "all sessions of the user", with the actor (the user itself, an admin, the system) and the reason, in both pools. Check first what the backend specification's activity section lists, and add the events there.

Acceptance

  • Each way a session ends writes a row, or the specification says why it does not.
  • Tests per event.

Noted in the reviews of #3199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:identityUsers, authorization server, API keys and memberstype:featureNew capability

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions