Repository navigation
Report when the member mail limit holds per instance only - #3125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3073
The limit of one member mail a minute of each slot to an address is kept in
IDistributedCache, so with the defaultMemoryDistributedCacheit holds per instance. The startup report now listsmember-mail-limit-per-instance(warning 9131) in Production while an email sender is set up and the resolved cache is the in-memory one, worded as a condition: it holds per instance, and with several instances a sharedIDistributedCacheis needed. Spec 4.7 and 4.15 (multi-instance and startup diagnostics),docs/host-configuration.mdand the production setup ofdocs/docker.mdname the requirement, the last next to the output cache.Decisions
forgot-passwordandresend-verificationare open whether or not registration is, so the line does not askAllowRegistration; it asks whether mail can go out at all (the sender is not the refusing default of Production). Without a sender no member mail goes, and the line would be noise.IDistributedCacheis checked withis MemoryDistributedCache, the same testMemberMailLimitermakes, so the report and the limiter agree. It is resolved only in Production with a sender; the default is cheap and a Redis cache connects on first use.Tests
StartupReportTests.TheMemberMailLimitInTheInMemoryCacheIsReportedInProductionWhileMailGoesOut: listed in Production with SMTP and the default cache; absent without a sender, with a shared cache, and in Staging.-warnaserror; SDK, Core and Architecture tests;StartupReportTests; markdownlint.