Repository navigation
fix(slurm): import logger in the function task connector - #3481
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
SlurmFunctionConnector.get() calls logger.info/debug but never imports it, so polling any Slurm function task raised NameError after reading the job state. Import the flytekit logger like the script connector does and cover get() with a test. Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
pcbeingused333
requested review from
cosmicbboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
November 1, 2026 07:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlurmFunctionConnector.get()(plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py) callslogger.info(...)after reading the job's stdout, andlogger.debug(...)when the stdout file is missing, but the module never importslogger. Every poll of a Slurm function task therefore raisedNameError: name 'logger' is not definedright after the job state was read. The script connector in the same plugin already doesfrom flytekit.loggers import logger.The fix is that one import.
Test:
tests/test_slurm_fn_connector.pyrunsget()against a mocked SSH/SFTP connection, once with the stdout file present and once withSFTPNoSuchFile. Both fail with theNameErroron main and pass with the import.Disclosure: this change was prepared with the help of an AI coding assistant (Claude Code) and submitted by the account owner.