Skip to content

feat(alerting): Add subscriptions alerts API - #367

Merged
vincent-pochet merged 3 commits into
mainfrom
feat/add-subscriptions-alerts
Oct 27, 2026
Merged

vincent-pochet merged 3 commits into
mainfrom
feat/add-subscriptions-alerts

Conversation

@vankiru

@vankiru vankiru commented Feb 11, 2026 •

Copy link
Copy Markdown
Contributor

Context

The client can only create or delete subscription alerts in batch (create_alerts, delete_alerts). The API also exposes one alert at a time under /subscriptions/:external_id/alerts, which the client did not cover.

Description

  • Add client.subscriptions.alerts, built on the nested command mixins like the wallet alerts client (feat(alerting): Add wallet alerts API #368).
  • find_all(subscription_id, options=...) lists alerts, find(subscription_id, code) reads one.
  • create(subscription_id, alert) creates one, update(subscription_id, code, alert) sends a PUT.
  • destroy(subscription_id, code) deletes one.

The batch methods on SubscriptionClient are unchanged. Related API PR: getlago/lago-api#4925.

🤖 Generated with Claude Code

@vankiru
vankiru changed the base branch from main to feat/move-wallets-api-to-customer-wallets February 11, 2026 16:42
@vankiru vankiru changed the title feat(alerting): Add wallet alerts API feat(alerting): Add subscriptions alerts API Feb 11, 2026

@annvelents annvelents left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked all the values for Alerts for both: you and me and updated my model to include values that you have. The only difference we have now is Alert vs AlertInput

Comment thread lago_python_client/models/alert.py
Comment thread lago_python_client/models/alert.py
Comment thread lago_python_client/models/alert.py
Comment thread lago_python_client/models/alert.py Outdated
Comment thread lago_python_client/models/alert.py Outdated
@vankiru
vankiru force-pushed the feat/add-subscriptions-alerts branch from a45c8d2 to 3f12610 Compare February 12, 2026 11:54
@vankiru
vankiru marked this pull request as ready for review February 12, 2026 12:05
@vankiru
vankiru force-pushed the feat/move-wallets-api-to-customer-wallets branch from 6196069 to f834aad Compare February 17, 2026 09:49
@vankiru
vankiru force-pushed the feat/add-subscriptions-alerts branch from 3f12610 to 041ee4e Compare February 17, 2026 10:14
@vankiru
vankiru force-pushed the feat/move-wallets-api-to-customer-wallets branch from f834aad to 5c93b73 Compare March 2, 2026 08:30
Base automatically changed from feat/move-wallets-api-to-customer-wallets to main March 2, 2026 09:05
@vankiru
vankiru force-pushed the feat/add-subscriptions-alerts branch 2 times, most recently from 5a17cce to 043326e Compare March 12, 2026 15:38
@vincent-pochet
vincent-pochet force-pushed the feat/add-subscriptions-alerts branch from 043326e to 00cbb2d Compare October 27, 2026 16:07
vankiru and others added 3 commits October 27, 2026 17:34
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The API only finds active subscriptions unless subscription_status is
given, so alerts of pending or terminated subscriptions were out of
reach. The nested mixins now take an optional options query, and the
subscription alerts client exposes subscription_status like the batch
alert methods. The client also inherits the rate-limit settings of its
parent, and the tests check the create and update payloads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vincent-pochet
vincent-pochet force-pushed the feat/add-subscriptions-alerts branch from d7d7654 to 6414b63 Compare October 27, 2026 16:35
@vincent-pochet
vincent-pochet merged commit 7a6f90e into main Oct 27, 2026
7 checks passed
@vincent-pochet
vincent-pochet deleted the feat/add-subscriptions-alerts branch October 27, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants