Skip to content

fix(link-pilot): keep listing text in English - #1277

Merged
paseo-bot[bot] merged 1 commit into
getpaseo:mainfrom
xzthemeofsss:codex/link-pilot-english-listing
Oct 27, 2026
Merged

paseo-bot[bot] merged 1 commit into
getpaseo:mainfrom
xzthemeofsss:codex/link-pilot-english-listing

Conversation

@xzthemeofsss

Copy link
Copy Markdown
Contributor

Summary

Keep Link Pilot's listing title, one-sentence description and overview in English for every locale, as requested by the author.

- artifact/repository commit: ef46ba62a203c89c0d160551a98008d32fed9d07
+ artifact/repository commit: 9d09493e4f29ae803e70d2a8cbf7651b560c84ba

The new pin removes the manifest's Chinese listing translation and OVERVIEW.zh-CN.md, so Chinese clients use the English defaults. Runtime settings, commands, errors and gallery media are unchanged. No runtime code or dependency changes. Keep the listing English-only; do not add reviewer translations. This updates the artifact approved in #1265.

Evidence

  • Before: the Chinese locale shows a translated name, description and overview from the approved artifact.
    After: the manifest supplies only Link Pilot and Choose where chat links open for a click or Command-click.; the only shipped overview is OVERVIEW.md.
  • Source typecheck, lint and formatting passed. Package dry run confirms the English overview is present and no translated overview is shipped.
  • Trusted-main registry validation passed: TMPDIR=/private/tmp npm run validate -- --online --changed --base origin/main reported 393 well-formed records and one record matching its pinned artifact. The canonical temporary path avoids macOS's /var symlink alias; registry scripts are unchanged.
  • Source correction: 9d09493. Publication awaits registry review and deployment.

Merge Danger

Door: Two-way

Revert the pin to restore the previous listing content.

Blast Radius: Listing

Only xzthemeofsss/link-pilot changes. Existing submit/publication/review timestamps are preserved for the reviewer; runtime behavior is unchanged.

@paseo-bot paseo-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link Pilot’s English-only listing update is approved, @xzthemeofsss. The new pin removes the Chinese listing translation while keeping localized runtime controls and existing media. No registry edits or further action are needed.

Review data
  • Reviewed head: daaeac21366e7621845293fb4c55dfd6fdbf1f8d. Main REVIEW.md blob: 8da1286fd8870c87ff53767e8644858627b7371f. Read this PR, original review #1265 and submission #1264; source owner, submitter and record attribution match.
  • Git source https://github.com/xzthemeofsss/paseo-plugins.git, plugin path plugins/link-pilot. Independently fetched and extracted approved ef46ba62a203c89c0d160551a98008d32fed9d07 and proposed 9d09493e4f29ae803e70d2a8cbf7651b560c84ba. Checked all 36/35 archive entries for safe paths and regular files/directories before extraction; no hooks or submodules.
  • Independent plugin-directory comparison: removes manifest translations and OVERVIEW.zh-CN.md; removes the translated-overview package file pattern and formatter argument; updates README and marketplace notes. Client/server/shared runtime modules, icon/images, dependency declarations and lockfile are unchanged. No new runtime access or execution path was introduced. The prior complete runtime inspection remains supporting evidence; this is an update review of the changed listing and packaging.
  • Installation: no production dependencies, manifest build command or install lifecycle script. Development commands are not installation steps. No plugin or dependency code installed, built, imported or run.
  • Listing: read the English overview and manifest description, verified the translated overview/metadata are absent, and retained the existing settings images. Reviewed the English settings image again; all image bytes match the previously approved tree. There are no registry translation or overview overrides, so English defaults apply to every locale. Runtime localization remains unchanged.
  • Existing behavior disclosed in the retained overview: assistant-link interception reads clicked URLs, app workspace/pane context and same-origin app modules; saved settings select in-app or system-browser opening. The chosen browser visits the selected URL. The prior review found no independent telemetry/backend, credential collection, subprocess, installer or model-provider request. Private-interface compatibility remains a limitation; this review did not repeat live desktop/UI tests or exhaustively audit unchanged host libraries.
  • Trusted current registry online validation passes: 393 records well-formed, one record matches its pinned artifact. Exact-head Validate CI passed. Only the intended plugin record changes in the registry; original attribution and first-publication date retained.

@paseo-bot
paseo-bot Bot merged commit 48bf6c1 into getpaseo:main Oct 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant