Repository navigation
Review Update browser-prompt to 0.10.3 - #1656
Merged
Merged
Conversation
2 of 9 tasks
Contributor
There was a problem hiding this comment.
Browser Prompt 0.10.3 is approved, @midego1. I pinned your requested revision and removed the intake file. Your description, overview and interface media are retained, including the clarification about model instructions; nothing is required from you.
Review data
- Policy: main
REVIEW.mdblob3c5e763c9565b93ea33fa48c9aeb83e415c72d67. Reviewed registry head5205ff14b3a49b9c60105cdaac8f04a418f65143. - Git artifact:
https://github.com/midego1/paseo-browser-prompt.git, root at requested commit4e868613086d2b5ae389ce54211bcdb65b64f720, version 0.10.3. Compared against current main's accepteded2c61849102ba3b475e8095f779662620321ba8. Submission identity agrees with the accepted listing and original submission. - Independently fetched both commits without hooks or submodules, checked every archive path/type before confined extraction (111 old, 115 new). Archive SHA-256: old
2bda837c4a519f0649f82cb1b39cdf999cefcee25dd7638303b96c969cc959ed, new1dcd19ab9c993fb0ea4c9b5227943e0ef126fbc875f3613ed2a5e39709f85fef. - Read the full production diff, new lock/RPC modules, card integration, server registration, updater consent path and invoked update implementation, package/lock changes and displayed English overview. Revisited agent creation and update-consent UI. Unchanged launcher, report forwarding and other runtime paths retain the accepted previous review's scope; development/demo scripts are not installation or runtime inputs and were not exhaustively audited.
- Run lock: clicking Run acquires an in-memory lock keyed by source chat and block fingerprint. It is bounded to 500 entries, expires abandoned starts after three minutes, and briefly records a started agent. Failure or a five-second RPC timeout allows the start without that lock, so duplicate prevention depends on daemon responsiveness. The lock adds no network destination, filesystem access or executable text path.
- Automatic updates now reread settings and current installation after acquiring the update lock; revoked consent, unreadable state or a changed remote returns without installation. The existing subprocess receives a validated commit as a positional argument. Registry installs remain outside this self-update path. This is static verification, not an executed concurrency or updater test.
- Existing purposeful access: selected ChatGPT app/web handoff and clipboard writes; user-started agents send steps to their provider, and configured reports/questions send bounded run text to the source agent/provider. Launcher uses owned Tailscale or loopback binding. Settings and updater/run state remain local. The overview now explicitly distinguishes model instructions from tool restrictions. No new credential extraction, unrelated collector or concrete malicious behavior found in the inspected changes.
- Packaging: no manifest build command, installed runtime dependencies or installation lifecycle script. Runtime externals are host supplied. Lock changes only update root version metadata; dependency entries are unchanged. All static local imports resolve. No plugin or dependency code installed, built, imported or executed.
- Registry edits: updated artifact/repository commit and review date in
plugins/midego1/browser-prompt.json, removedsubmissions/1655.json; preserved author description/overview and all media. The four media blobs are unchanged from the accepted artifact; their new pinned URLs return HTTP 200 and matching GIF/PNG content types. - Trusted main registry tests: 189 passed. Committed-tree online changed-record validation: 441 well-formed records, one matching artifact. No fresh live browser/provider/UI test or exhaustive dependency audit; prompt behavior still depends on the selected model and provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1655. Submitted by @midego1.
Ready for artifact review. The reviewer will resolve the submitted source and complete the registry listing.
Submission:
submissions/1655.json.Git references are optional. Use a supplied reference; otherwise resolve main during review. Git updates are submitted manually.