Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Services awaiting deployment · Rollout details
Mention |
Lms24
left a comment
There was a problem hiding this comment.
This looks good to me based on the docs structure we have today. Just had minor wording suggestions mostly.
One Follow-up suggestion: I think we could add something like a "Tunneling" page to the extended configuration section where we display most of the content we now have in "Troubleshooting" and "ServeTunnel" integration docs. Then we link from both pages to that new page. I think this is better than having so much content in troubleshooting. WDYT?
Adds the serveTunnelIntegration page, the browser tunnel: true option, a managed tunnel section in troubleshooting, framework getting-started snippets, and updates TanStack Start tunnelRoute docs for 11.10.0.
Covers the tunnel helpers every server SDK exports and the new handleTunnelRequest signature from getsentry/sentry-javascript#25783.
Hides SolidStart until it serves the managed tunnel, fixes the Cloudflare example, and notes that the manual helpers need serveTunnelIntegration to drop tunnel spans.
The serveTunnel page only exists on server platforms, so the links 404'd on browser-only ones.
… serve the tunnel On servers without a framework SDK hook, including Cloudflare Workers, the integration only configures the tunnel.
Add a Tunneling page under Extended Configuration and move the tunnel content there from Troubleshooting, which now only links to it. Point existing tunneling links at the new page. Also address review feedback on the managed tunnel docs: list serveTunnelIntegration in the server integration tables, add a Fastify example, and tighten the tunnel option wording.
ebe3a6d to
03766f6
Compare
|
@Lms24 thanks for the review, I took a holistic view on this after a few iterations and I feel the tunnel entire story is confusing. So I'm pulling this back for a few days till I get it right. I'm working on a different idea that could make this way easier to document with less edge cases: getsentry/sentry-javascript#25917 The idea I have in my mind is getting |
Browser events still get dropped by ad blockers unless users write their own tunnel, this is now shipped in v11.10.