Repository navigation
Conversation
Prevent caller mutations to SpanOptions and TransactionOptions from changing spans and transactions after they have been created. Copy span options before applying explicit timestamps in native and OpenTelemetry paths. Fixes #6416 Co-Authored-By: Claude <noreply@anthropic.com>
4 of 9 tasks
📲 Install BuildsAndroid
|
Apply the explicit timestamp argument to copied span options even when it is null. This matches native tracing while preserving caller-owned options. Refs #6416 Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Tracing API Cleanup)
📜 Description
Snapshots
SpanOptionsandTransactionOptionswhen spans and transactions are created. Deferred tracing behavior now uses the values captured at creation time instead of retaining caller-owned mutable option objects.Timestamp-based child creation also applies timestamps to copied options in both native and OpenTelemetry paths, including null timestamps, while leaving caller-owned options unchanged.
💡 Motivation and Context
Mutating tracing options after creating a span or transaction could change its trimming, idle handling, timer, child-waiting, or callback behavior. Timestamp-based child creation could also mutate the caller's
SpanOptionsinstance.Fixes #6416.
💚 How did you test it?
./gradlew :sentry:test./gradlew :sentry-opentelemetry:sentry-opentelemetry-core:test./gradlew :sentry:apiCheck spotlessCheck./gradlew spotlessApply updateKotlinAbi📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.