Repository navigation
Conversation
Active spans usually have no status until they finish, which causes trace contexts attached to events to appear as unknown. Default copied trace contexts to OK without mutating the running span, while preserving explicitly set statuses. Fixes GH-4769
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Default trace contexts created from active spans to
okwhen the span does not have an explicit status.The SDK copies the span context before applying the default, so the running span remains unchanged. Explicitly assigned span statuses continue to be preserved.
💡 Motivation and Context
Active spans usually do not have a status until they finish. When their context is attached to an event, feedback, check-in, replay, or persisted scope, Sentry currently displays the missing status as
unknown, which is confusing to users.This aligns Java with the span-first default and the equivalent Cocoa change.
💚 How did you test it?
./gradlew :sentry:test --rerun-tasks --tests io.sentry.SpanContextTest --tests io.sentry.ScopeTest --tests io.sentry.ScopesTest --tests io.sentry.SentryClientTest../gradlew spotlessApply updateKotlinAbi.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Run the SDK team review and address any findings.