Repository navigation
Conversation
Stop injecting sentry-trace and baggage for URL-less outgoing spans so tracePropagationTargets can be enforced consistently. Preserve propagation for producer spans because messaging carriers do not have a URL. BREAKING CHANGE: URL-less non-producer spans no longer receive Sentry tracing headers. Fixes #5725 Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Use server.address and optional server.port as propagation targets for URL-less client spans. Preserve gRPC and other destination-aware client propagation while keeping unknown carriers fail-closed. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Stop the Sentry OpenTelemetry propagators from injecting
sentry-traceandbaggagewhen an outgoing span does not provide a URL. URL-bearing spans continue to be checked againsttracePropagationTargets.Messaging producer spans remain eligible for propagation without a URL because OpenTelemetry queue and messaging instrumentations use
SpanKind.PRODUCERand inject trace context into message metadata.Document the propagation behavior for both the standard and OTLP OpenTelemetry integrations.
💡 Motivation and Context
Previously, a missing URL bypassed
tracePropagationTargetsand caused tracing headers to be attached to an unknown outgoing carrier. This changes that behavior for 9.x while preserving distributed tracing for queue producers, which legitimately do not have URL attributes.💚 How did you test it?
./gradlew ':sentry-opentelemetry:sentry-opentelemetry-core:test' ':sentry-opentelemetry:sentry-opentelemetry-otlp:test'./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps