Repository navigation
ci(contrib): Exclude organization members from credits - #2271
Merged
Merged
Conversation
Check membership with the app token because `author_association` can classify organization members as contributors. Skip their credits and fail on lookup errors. Follow existing workflows: - `getsentry/sentry`: `.github/workflows/sentry-pull-request-bot.yml` checks membership with `github.rest.orgs.checkMembershipForUser`. - `getsentry/sentry-docs`: `.github/workflows/codeowner_assignment.yaml` requests `permission-members: read` on its GitHub App token. Close: #2270
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2271 +/- ##
==========================================
+ Coverage 75.67% 75.71% +0.03%
==========================================
Files 103 103
Lines 28319 28319
Branches 5210 5210
==========================================
+ Hits 21431 21442 +11
+ Misses 5550 5527 -23
- Partials 1338 1350 +12 🚀 New features to boost your workflow:
|
JoshuaMoelans
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check membership with the app token because
author_associationcan classify organization members as contributors. Skip their credits and fail on lookup errors.Follows the example of existing
getsentryworkflows:getsentry/sentry/.github/workflows/sentry-pull-request-bot.ymlchecks membership withgithub.rest.orgs.checkMembershipForUser.getsentry/sentry-docs/.github/workflows/codeowner_assignment.yamlrequestspermission-members: readon its GitHub App token.Close: #2270