Repository navigation
ref(client-report): Narrow ClientReportAggregator reports key type to drop Mago baseline entry - #2397
Merged
Conversation
… drop Mago baseline entry
Litarnus
approved these changes
Nov 19, 2026
Litarnus
marked this pull request as ready for review
November 19, 2026 09:56
Litarnus
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes this Mago baseline entry from
analysis-baseline.toml:src/ClientReport/ClientReportAggregator.php·less-specific-argument· Argument type mismatch for argument Add easy install of set_error_handler #1 ofSentry\ClientReport\DiscardedEvent::__construct: expectedstring, but provided typearray-keyis less specific.The
$reportsproperty was documented asarray<array<string, int>>, so the outer (category) key wasarray-keyandflush()passed it toDiscardedEvent, which takes astring. The outer key is alwaysDataCategory::getValue(), a non-numeric string likeerrorortransaction, so the docblock is nowarray<string, array<string, int>>, matching the inner reason key.Docblock-only change, no runtime behavior change.
via automation
sched_a59acc45df166a80a839d0b32321e740· Run IDsched_a59acc45df166a80a839d0b32321e740:1795078800000.--
View Session [Sentry]