Skip to content

ref(client-report): Narrow ClientReportAggregator reports key type to drop Mago baseline entry - #2397

Merged
Litarnus merged 1 commit into
masterfrom
ref/client-report-aggregator-category-key-type
Nov 19, 2026
Merged

Litarnus merged 1 commit into
masterfrom
ref/client-report-aggregator-category-key-type

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Removes this Mago baseline entry from analysis-baseline.toml:

  • src/ClientReport/ClientReportAggregator.php · less-specific-argument · Argument type mismatch for argument Add easy install of set_error_handler #1 of Sentry\ClientReport\DiscardedEvent::__construct: expected string, but provided type array-key is less specific.

The $reports property was documented as array<array<string, int>>, so the outer (category) key was array-key and flush() passed it to DiscardedEvent, which takes a string. The outer key is always DataCategory::getValue(), a non-numeric string like error or transaction, so the docblock is now array<string, array<string, int>>, matching the inner reason key.

Docblock-only change, no runtime behavior change.

via automation sched_a59acc45df166a80a839d0b32321e740 · Run ID sched_a59acc45df166a80a839d0b32321e740:1795078800000.

--

View Session [Sentry]

@Litarnus
Litarnus marked this pull request as ready for review November 19, 2026 09:56
@Litarnus
Litarnus requested review from a team and stayallive as code owners November 19, 2026 09:56
@Litarnus
Litarnus merged commit b44566c into master Nov 19, 2026
60 checks passed
@Litarnus
Litarnus deleted the ref/client-report-aggregator-category-key-type branch November 19, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant