Skip to content

ref(spotlight): Type SpotlightClient::sendRequest() url as non-empty-string to drop PHPStan baseline entry - #2408

Draft
sentry-junior[bot] wants to merge 1 commit into
masterfrom
chore/phpstan-baseline-spotlight-client-url
Draft

sentry-junior[bot] wants to merge 1 commit into
masterfrom
chore/phpstan-baseline-spotlight-client-url

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Removes this PHPStan baseline entry:

  • src/Spotlight/SpotlightClient.php: Parameter #3 $value of function curl_setopt expects non-empty-string, string given. (count 1)

CURLOPT_URL needs a non-empty string. SpotlightClient::sendRequest() now documents $url as non-empty-string with a @param tag. Its only caller, HttpTransport, passes getSpotlightUrl() . '/stream', which PHPStan already infers as non-empty.

Nothing breaks: the change only touches a docblock on an @internal class. The native signature and runtime behavior stay the same.

via automation sched_a59acc45df166a80a839d0b32321e740 · Run ID sched_a59acc45df166a80a839d0b32321e740:1795165200000.

--

View Session [Sentry]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants