Skip to content

C#: NuGet CLI proxy environment. #22752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 6 commits into from
Oct 7, 2026
Merged

C#: NuGet CLI proxy environment. #22752

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d62fae8
C#: Re-factor logic for setting .NET proxy environment variables into…
michaelnebel Oct 5, 2026
2f3f6df
C#: Set proxy environment variables for sub-process invoking the NuGe…
michaelnebel Oct 5, 2026
36395a3
C#: Also set lower case versions of the proxy environment variables.
michaelnebel Oct 6, 2026
983d936
C#: Log the NuGet CLI command before executing it.
michaelnebel Oct 6, 2026
16ebfc8
C#: Add change-note.
michaelnebel Oct 6, 2026
2e0f0c4
C#: Address review comments.
michaelnebel Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions csharp/ql/lib/change-notes/2026-10-05-nugetcli-proxy-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Proxy and certificate environment variables are now set for the subprocess that invokes the NuGet CLI, enabling it to access private registries during this part of the workflow.

@mbg mbg Oct 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Change "Proxy" to "Private registry proxy" to disambiguate from ordinary proxies that may be configured on a system. Alternatively, since "private registries" are already mentioned in the last part of the note, restructure the sentence to emphasise that part. For example:

Suggested change
* Proxy and certificate environment variables are now set for the subprocess that invokes the NuGet CLI, enabling it to access private registries during this part of the workflow.
* The subprocess for the NuGet CLI is now provided with the proxy and certificate environment variables needed to access private registries if any are configured.

Loading