Skip to content

JS: Add taint steps for trimStart, trimEnd and normalize #22853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 1 commit into from
Oct 21, 2026
+14 −4
Merged

JS: Add taint steps for trimStart, trimEnd and normalize #22853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/ql/lib/change-notes/2026-10-20-string-trim-normalize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added taint steps for `String.prototype.trimStart`, `trimEnd`, and `normalize`.
8 changes: 4 additions & 4 deletions javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,10 +455,10 @@ module TaintTracking {
name =
[
"anchor", "big", "blink", "bold", "concat", "fixed", "fontcolor", "fontsize",
"italics", "link", "padEnd", "padStart", "repeat", "replace", "replaceAll", "slice",
"small", "strike", "sub", "substr", "substring", "sup", "toLocaleLowerCase",
"toLocaleUpperCase", "toLowerCase", "toUpperCase", "trim", "trimLeft", "trimRight",
"toWellFormed"
"italics", "link", "normalize", "padEnd", "padStart", "repeat", "replace",
"replaceAll", "slice", "small", "strike", "sub", "substr", "substring", "sup",
"toLocaleLowerCase", "toLocaleUpperCase", "toLowerCase", "toUpperCase", "trim",
"trimEnd", "trimLeft", "trimRight", "trimStart", "toWellFormed"
]
or
// sorted, interesting, properties of Object.prototype
Expand Down
6 changes: 6 additions & 0 deletions javascript/ql/test/library-tests/TripleDot/string-trim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
function trimming() {
sink(source('trimStart').trimStart()); // $ hasTaintFlow=trimStart
sink(source('trimEnd').trimEnd()); // $ hasTaintFlow=trimEnd
sink(source('normalize').normalize('NFC')); // $ hasTaintFlow=normalize
sink(source('trimLeft').trimLeft()); // $ hasTaintFlow=trimLeft
}
Loading