Repository navigation
Move drained slab metadata ablation to InitializeFromExperiments. - #1714
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
`Parameters::release_drained_slab_metadata()` checked a `LowLevelCallOnce`
flag on every read to apply `TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION`.
Apply the experiment in `Parameters::InitializeFromExperiments()` with the
other experiment-defaulted parameters, and make the getter a plain load.
`TCMalloc_Internal_{Get,Set}ReleaseDrainedSlabMetadata` call
`InitIfNecessary()` first, like the other parameters initialized there, so an
explicit setting still wins over the experiment.
PiperOrigin-RevId: 1006750346
copybara-service
Bot
force-pushed
the
test_1006750346
branch
from
October 26, 2026 16:20
dbd2f4b to
b013cac
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move drained slab metadata ablation to InitializeFromExperiments.
Parameters::release_drained_slab_metadata()checked aLowLevelCallOnceflag on every read to apply
TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION.Apply the experiment in
Parameters::InitializeFromExperiments()with theother experiment-defaulted parameters, and make the getter a plain load.
TCMalloc_Internal_{Get,Set}ReleaseDrainedSlabMetadatacallInitIfNecessary()first, like the other parameters initialized there, so anexplicit setting still wins over the experiment.