Repository navigation
fix(md): escape template literal characters in bash fence blocks - #1530
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1529
Summary
In
src/md.ts, bash code fences (```bash) are wrapped into JavaScript tagged template literals (await $...). When bash commands contain parameter expansions such as `${VAR}` or backticks for command substitution (e.g.date``), the unescaped characters were interpreted as JS template interpolation or terminated the template literal early, leading toReferenceErroror `SyntaxError`.Changes
\,`, and${in bash fence lines before embedding them in the template literal.$VAR) and command substitutions ($(cmd)) continue to pass through unmodified.test/md.test.tsto ensure${...}and backtick expressions in bash fences are escaped and executed as intended shell syntax.