Repository navigation
feat(dbkit/sqlite): let callers match the snapshot errors for an unsupported file system - #157
Conversation
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] The reviewed changes appear safe to merge.
|
There was a problem hiding this comment.
Gates Passed
4 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Closes #156
What
ErrUnsupportedFileSystem. A snapshot error matches it witherrors.Iswhen the snapshot folder is on a network or FUSE file system, and when its file system cannot move a file without replacing one.UnsupportedFileSystemError, read witherrors.As.Foldernames the snapshot folder.FileSystemnames the network or FUSE file system, and is empty in the move case.Errholds the error of the failed move, and is nil for the check before the lock.net/http.Why
A downstream application writes its own message for these two failures, with the setting its user should change. Until now it could only tell them apart by matching dbkit's text.
The vulnerability scan fails on Go 1.27.3 in every module that reaches the affected
net/httpcode, so this pull request could not pass without the move.Testing Instructions
dbkit/sqlite.errors.Asgives the folder andsmbfs.Summary by CodeRabbit